Skip to content

Conversation

voetberg
Copy link
Contributor

No description provided.

@voetberg voetberg force-pushed the cli_migration branch 2 times, most recently from 8e13657 to 72d48ee Compare January 17, 2025 20:37
@voetberg voetberg requested a review from rdimaio January 23, 2025 14:49
Copy link
Contributor

@rdimaio rdimaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing

Run ./tools/check-file-names.sh
migrate_to_36_CLI.md does not comply with the snakecase convention!

@voetberg voetberg force-pushed the cli_migration branch 4 times, most recently from 2f45a02 to 231d8f2 Compare January 23, 2025 16:51
Copy link
Contributor

@rdimaio rdimaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like there's two duplicate files now, migrate_36_cli.md and migrate_to_36_cli.md

"items": [
{"type": "autogenerated", "dirName": "operator"},
],
"User": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I got distracted in the middle of rebasing and have to go back and fix some things 🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants